Skip to content

Scheduler - Appointment Form - Fix resource items' names#32848

Merged
Tucchhaa merged 5 commits intoDevExpress:26_1from
Tucchhaa:fix_resource_editor_name_26_1
Mar 11, 2026
Merged

Scheduler - Appointment Form - Fix resource items' names#32848
Tucchhaa merged 5 commits intoDevExpress:26_1from
Tucchhaa:fix_resource_editor_name_26_1

Conversation

@Tucchhaa
Copy link
Contributor

No description provided.

@Tucchhaa Tucchhaa self-assigned this Mar 10, 2026
@Tucchhaa Tucchhaa added the 26_1 label Mar 10, 2026
@Tucchhaa Tucchhaa marked this pull request as ready for review March 11, 2026 11:18
@Tucchhaa Tucchhaa requested a review from a team as a code owner March 11, 2026 11:18
Copilot AI review requested due to automatic review settings March 11, 2026 11:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Scheduler appointment form item naming for resources to use explicit editor/group names, and updates tests and demo form customizations to match the new names.

Changes:

  • Rename resource editor items from <fieldExpr> to <fieldExpr>Editor and rename the “resources content” group to resourceEditorsGroup.
  • Update appointment popup tests to assert the new item names and simplify resource setup.
  • Update Scheduler demo apps (jQuery/Vue/React/Angular) to reference the new resource item names in editing.form.items.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/devextreme/js/__internal/scheduler/appointment_popup/m_form.ts Renames default resource-related form item/group names to a consistent *Editor / resourceEditorsGroup scheme.
packages/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.test.ts Adjusts assertions to the new item names and uses itemOption to access nested groups.
apps/demos/Demos/Scheduler/Resources/jQuery/index.js Updates form item names to roomIdEditor / priorityIdEditor.
apps/demos/Demos/Scheduler/Resources/Vue/App.vue Updates form item names to roomIdEditor / priorityIdEditor.
apps/demos/Demos/Scheduler/Resources/ReactJs/App.js Updates form item names to roomIdEditor / priorityIdEditor.
apps/demos/Demos/Scheduler/Resources/React/App.tsx Updates form item names to roomIdEditor / priorityIdEditor.
apps/demos/Demos/Scheduler/Resources/Angular/app/app.component.html Updates form item names to roomIdEditor / priorityIdEditor.
apps/demos/Demos/Scheduler/ResolveTimeConflicts/jQuery/index.js Updates the customized resource editor item name to assigneeIdEditor.
apps/demos/Demos/Scheduler/ResolveTimeConflicts/Vue/App.vue Updates the customized resource editor item name to assigneeIdEditor.
apps/demos/Demos/Scheduler/ResolveTimeConflicts/ReactJs/App.js Updates the customized resource editor item name to assigneeIdEditor.
apps/demos/Demos/Scheduler/ResolveTimeConflicts/React/App.tsx Updates the customized resource editor item name to assigneeIdEditor.
apps/demos/Demos/Scheduler/ResolveTimeConflicts/Angular/app/app.component.html Updates the customized resource editor item name to assigneeIdEditor.
apps/demos/Demos/Scheduler/IndividualViewsCustomization/jQuery/index.js Updates form item names to priorityIdEditor / typeIdEditor.
apps/demos/Demos/Scheduler/IndividualViewsCustomization/Vue/App.vue Updates form item names to priorityIdEditor / typeIdEditor.
apps/demos/Demos/Scheduler/IndividualViewsCustomization/ReactJs/App.js Updates form item names to priorityIdEditor / typeIdEditor.
apps/demos/Demos/Scheduler/IndividualViewsCustomization/React/App.tsx Updates form item names to priorityIdEditor / typeIdEditor.
apps/demos/Demos/Scheduler/IndividualViewsCustomization/Angular/app/app.component.html Updates form item names to priorityIdEditor / typeIdEditor.
Comments suppressed due to low confidence (1)

packages/devextreme/js/__internal/scheduler/appointment_popup/m_form.ts:797

  • The resources subgroup name was changed from resourcesGroupContent to resourceEditorsGroup. There is still an in-repo usage of the old name (and old resource item names) in apps/react-storybook/stories/scheduler/SchedulerFormCustomization.stories.tsx, which will no longer match the default items and will render/merge incorrectly. Please update that story (and any other examples/docs) to the new names in the same PR, or keep an alias for resourcesGroupContent.
        items: [
          {
            name: RESOURCES_GROUP_ICON_NAME,
            colSpan: 1,
            cssClass: `${CLASSES.formIcon} ${CLASSES.defaultResourceIcon}`,
            template: createFormIconTemplate('addcircleoutline'),
          },
          {
            name: RESOURCE_EDITORS_GROUP_NAME,
            itemType: 'group',
            colSpan: 1,
            items: resourcesItems,
          },

You can also share your feedback on Copilot code review. Take the survey.

@Tucchhaa Tucchhaa merged commit a42a44e into DevExpress:26_1 Mar 11, 2026
110 checks passed
@Tucchhaa Tucchhaa deleted the fix_resource_editor_name_26_1 branch March 11, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants