Scheduler - Appointment Form - Fix resource items' names#32848
Merged
Tucchhaa merged 5 commits intoDevExpress:26_1from Mar 11, 2026
Merged
Scheduler - Appointment Form - Fix resource items' names#32848Tucchhaa merged 5 commits intoDevExpress:26_1from
Tucchhaa merged 5 commits intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Scheduler appointment form item naming for resources to use explicit editor/group names, and updates tests and demo form customizations to match the new names.
Changes:
- Rename resource editor items from
<fieldExpr>to<fieldExpr>Editorand rename the “resources content” group toresourceEditorsGroup. - Update appointment popup tests to assert the new item names and simplify resource setup.
- Update Scheduler demo apps (jQuery/Vue/React/Angular) to reference the new resource item names in
editing.form.items.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/__internal/scheduler/appointment_popup/m_form.ts | Renames default resource-related form item/group names to a consistent *Editor / resourceEditorsGroup scheme. |
| packages/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.test.ts | Adjusts assertions to the new item names and uses itemOption to access nested groups. |
| apps/demos/Demos/Scheduler/Resources/jQuery/index.js | Updates form item names to roomIdEditor / priorityIdEditor. |
| apps/demos/Demos/Scheduler/Resources/Vue/App.vue | Updates form item names to roomIdEditor / priorityIdEditor. |
| apps/demos/Demos/Scheduler/Resources/ReactJs/App.js | Updates form item names to roomIdEditor / priorityIdEditor. |
| apps/demos/Demos/Scheduler/Resources/React/App.tsx | Updates form item names to roomIdEditor / priorityIdEditor. |
| apps/demos/Demos/Scheduler/Resources/Angular/app/app.component.html | Updates form item names to roomIdEditor / priorityIdEditor. |
| apps/demos/Demos/Scheduler/ResolveTimeConflicts/jQuery/index.js | Updates the customized resource editor item name to assigneeIdEditor. |
| apps/demos/Demos/Scheduler/ResolveTimeConflicts/Vue/App.vue | Updates the customized resource editor item name to assigneeIdEditor. |
| apps/demos/Demos/Scheduler/ResolveTimeConflicts/ReactJs/App.js | Updates the customized resource editor item name to assigneeIdEditor. |
| apps/demos/Demos/Scheduler/ResolveTimeConflicts/React/App.tsx | Updates the customized resource editor item name to assigneeIdEditor. |
| apps/demos/Demos/Scheduler/ResolveTimeConflicts/Angular/app/app.component.html | Updates the customized resource editor item name to assigneeIdEditor. |
| apps/demos/Demos/Scheduler/IndividualViewsCustomization/jQuery/index.js | Updates form item names to priorityIdEditor / typeIdEditor. |
| apps/demos/Demos/Scheduler/IndividualViewsCustomization/Vue/App.vue | Updates form item names to priorityIdEditor / typeIdEditor. |
| apps/demos/Demos/Scheduler/IndividualViewsCustomization/ReactJs/App.js | Updates form item names to priorityIdEditor / typeIdEditor. |
| apps/demos/Demos/Scheduler/IndividualViewsCustomization/React/App.tsx | Updates form item names to priorityIdEditor / typeIdEditor. |
| apps/demos/Demos/Scheduler/IndividualViewsCustomization/Angular/app/app.component.html | Updates form item names to priorityIdEditor / typeIdEditor. |
Comments suppressed due to low confidence (1)
packages/devextreme/js/__internal/scheduler/appointment_popup/m_form.ts:797
- The resources subgroup name was changed from
resourcesGroupContenttoresourceEditorsGroup. There is still an in-repo usage of the old name (and old resource item names) inapps/react-storybook/stories/scheduler/SchedulerFormCustomization.stories.tsx, which will no longer match the default items and will render/merge incorrectly. Please update that story (and any other examples/docs) to the new names in the same PR, or keep an alias forresourcesGroupContent.
items: [
{
name: RESOURCES_GROUP_ICON_NAME,
colSpan: 1,
cssClass: `${CLASSES.formIcon} ${CLASSES.defaultResourceIcon}`,
template: createFormIconTemplate('addcircleoutline'),
},
{
name: RESOURCE_EDITORS_GROUP_NAME,
itemType: 'group',
colSpan: 1,
items: resourcesItems,
},
You can also share your feedback on Copilot code review. Take the survey.
aleksei-semikozov
approved these changes
Mar 11, 2026
sjbur
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.